-
Notifications
You must be signed in to change notification settings - Fork 34
Register Fujitsu conformance test results. #54
Conversation
@ta-Kuwayama is attempting to deploy a commit to the wbcsd Team on Vercel. A member of the Team first needs to authorize it. |
I don't know what caused validate to fail. |
"name": "Fujitsu Limited", | ||
"email": "[email protected]", | ||
"website": "https://www.fujitsu.com" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ta-Kuwayama - Thanks for submitting this PR. I see that the logo attribute is not mentioned in the user json. Please see an existing example here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prasadt1
Is logo a required option? README.md says optional.
We cannot prepare a publicly available corporate logo url
Is it possible to write "logo": "if it is not ready?
- Fill in your user's details
...
"logo": "" // to be displayed in the collaborators page (optional)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ta-Kuwayama
Ideally if you have a logo url then it is recommended, since our code will fetch the Logo from there. If it is not available for fujistsu, we can try without this attribute. No changes needed then. Thanks!
"tested_by": { | ||
"solution_name": "nri-cts", | ||
"version": "0.9.15", | ||
"solution_id": "NRI-CTS" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ta-Kuwayama - I guess the solution_id and solution_name for NRI are swapped. please update them and it works hopefully. See the NRI Solution json here
HI @prasadt1 |
No description provided.