Skip to content
This repository has been archived by the owner on Mar 28, 2024. It is now read-only.

Register Fujitsu conformance test results. #54

Merged
merged 5 commits into from
Jul 31, 2023
Merged

Conversation

ta-Kuwayama
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Jul 31, 2023

@ta-Kuwayama is attempting to deploy a commit to the wbcsd Team on Vercel.

A member of the Team first needs to authorize it.

@ta-Kuwayama
Copy link
Contributor Author

I don't know what caused validate to fail.
Could you tell me what's wrong?

"name": "Fujitsu Limited",
"email": "[email protected]",
"website": "https://www.fujitsu.com"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ta-Kuwayama - Thanks for submitting this PR. I see that the logo attribute is not mentioned in the user json. Please see an existing example here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prasadt1
Is logo a required option? README.md says optional.
We cannot prepare a publicly available corporate logo url
Is it possible to write "logo": "if it is not ready?

  1. Fill in your user's details
    ...
    "logo": "" // to be displayed in the collaborators page (optional)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ta-Kuwayama
Ideally if you have a logo url then it is recommended, since our code will fetch the Logo from there. If it is not available for fujistsu, we can try without this attribute. No changes needed then. Thanks!

"tested_by": {
"solution_name": "nri-cts",
"version": "0.9.15",
"solution_id": "NRI-CTS"
Copy link
Contributor

@prasadt1 prasadt1 Jul 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ta-Kuwayama - I guess the solution_id and solution_name for NRI are swapped. please update them and it works hopefully. See the NRI Solution json here

@prasadt1 prasadt1 merged commit cd6b046 into wbcsd:main Jul 31, 2023
1 check passed
@ta-Kuwayama
Copy link
Contributor Author

HI @prasadt1
I am sorry, I registered an email address that cannot be published to the outside, so I want to reverse the pull request and send the pull request again.
Also, could you please delete the pointed out comment with the email address of the above comment?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants